Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing password for Loki-Canary when loki.auth_enabled is true #12411

Merged
merged 9 commits into from
Apr 19, 2024
Merged

fix: Missing password for Loki-Canary when loki.auth_enabled is true #12411

merged 9 commits into from
Apr 19, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Mar 30, 2024 •
edited
Loading

What this PR does / why we need it:

When loki.auth_enabled is true, loki-canary cannot set a password. Add a password parameter to address this issue. Additionally, the functionality can also be achieved through existSecret, but this PR does not implement that feature.

Which issue(s) this PR fixes:
Fixes #10873

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@win5923 win5923 requested a review from a team as a code owner March 30, 2024 16:57
@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@win5923 win5923 changed the title fix: Missing password for Loki-Canary fix: Missing password for Loki-Canary when loki.auth_enabled is true Mar 30, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 1, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 1, 2024
@win5923
Copy link
Contributor Author

win5923 commented Apr 1, 2024

Hi @JStickler, this PR is ready. If there are any issues, please let me know. Thank you!

@JStickler JStickler requested a review from MichelHollands April 1, 2024 20:43
@JStickler
Copy link
Contributor

@win5923 I'm the technical writer on the team so I don't approve code PRs, but I tagged someone who can.

@win5923
Copy link
Contributor Author

win5923 commented Apr 6, 2024

@MichelHollands. Would you be able to review?

@MichelHollands
Copy link
Contributor

@win5923 Thanks for the contribution. If you rebase/merge on the latest version then I'll approve this.

@win5923 win5923 closed this Apr 19, 2024
@win5923 win5923 reopened this Apr 19, 2024
@win5923
Copy link
Contributor Author

win5923 commented Apr 19, 2024

@win5923 Thanks for the contribution. If you rebase/merge on the latest version then I'll approve this.

Done!

@MichelHollands
Copy link
Contributor

@win5923 Thanks for the contribution. If you rebase/merge on the latest version then I'll approve this.

Done!

Thanks but something went wrong. The new version should be 6.3.2

@MichelHollands
Copy link
Contributor

@win5923 1 more change is needed. The documentation needs to be updated. Please run the command mentioned in the failing CI step.

@win5923
Copy link
Contributor Author

win5923 commented Apr 19, 2024

Sorry for the delay, it's done!

@MichelHollands MichelHollands merged commit 68b23dc into grafana:main Apr 19, 2024
17 checks passed
This was referenced Apr 22, 2024
Closed
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@win5923 @JStickler @MichelHollands
fix: Missing password for Loki-Canary when loki.auth_enabled is true (g…
338bb55 
…rafana#12411)

Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm] Self-Monitoring fails when loki.auth_enabled is true and/or gateway.basicAuth.enabled is true
4 participants
@win5923 @CLAassistant @JStickler @MichelHollands